Skip to content

fix: track ssl flag in profile#298

Merged
drstrangelooker merged 1 commit into
mainfrom
fix-ssl-flag
Jun 26, 2026
Merged

fix: track ssl flag in profile#298
drstrangelooker merged 1 commit into
mainfrom
fix-ssl-flag

Conversation

@drstrangelooker

Copy link
Copy Markdown
Collaborator

fixes: #297

@drstrangelooker drstrangelooker requested a review from a team as a code owner June 26, 2026 16:58

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for configuring SSL settings per profile by adding an SSL field to the configuration and handling the --ssl flag when adding profiles or initializing the client. The review feedback focuses on improving robustness and test isolation: it recommends adding defensive nil checks when looking up the ssl flag in both production and test code to prevent potential nil pointer dereferences, and ensuring the ssl flag is properly reset in test cleanup blocks.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread internal/cmd/root.go Outdated
Comment thread internal/cmd/profile_test.go
Comment thread internal/cmd/profile_test.go
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

CI Tests

  4 files   24 suites   0s ⏱️
 95 tests  95 ✅ 0 💤 0 ❌
380 runs  380 ✅ 0 💤 0 ❌

Results for commit 668fd52.

♻️ This comment has been updated with latest results.

@drstrangelooker drstrangelooker merged commit 443385b into main Jun 26, 2026
19 checks passed
@drstrangelooker drstrangelooker deleted the fix-ssl-flag branch June 26, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support disabling ssl for a full profile

2 participants